Firebase.h updates for 8.0.0 #7914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
requested review from
charlotteliang,
christibbs,
eldhosembabu,
karenyz,
ryanwilson,
samedson and
visumickey
charlotteliang
approved these changes
Apr 16, 2021
visumickey
approved these changes
Apr 16, 2021
karenyz
approved these changes
Apr 16, 2021
ryanwilson
approved these changes
Apr 17, 2021
| @@ -1,6 +1,8 @@ | |||
| # Firebase 8.0.0 | |||
There was a problem hiding this comment.
Do you want to also mention removal of deprecated pods from the header?
samedson
reviewed
Apr 19, 2021
CoreOnly/Sources/Firebase.h
Outdated
| #import <Fabric/Fabric.h> | ||
| #endif | ||
| #if __has_include(<Crashlytics/Crashlytics.h>) |
There was a problem hiding this comment.
We can also remove old Crashlytics SDK
ryanwilson
reviewed
Apr 19, 2021
FirebaseCore/CHANGELOG.md
Outdated
| CocoaPod instead. (#7833) | ||
| - [removed] Build warnings will no longer be generated to warn about missing capabilities resulting | ||
| from not including FirebaseAnalytics in the app. See the Firebase docs instead. (#7487) | ||
| - [removed] Removed FirebaseMLModelInterpreter. Use FirebaseMLDownloader instead. |
There was a problem hiding this comment.
Nit: can you format these the same as the above Firebase/AdMob changelog? Maybe moving them all together as well (moving the Build warnings will... entry up to the top)
There was a problem hiding this comment.
Good catch. Thanks! Unified now.
ryanwilson
approved these changes
Apr 19, 2021
FirebaseCore/CHANGELOG.md
Outdated
| - [removed] The `Firebase/AdMob` CocoaPods subspec has been removed. Use the `Google-Mobile-Ads-SDK` | ||
| CocoaPod instead. (#7833) | ||
| - [removed] The `Firebase/FirebaseMLModelInterpreter` CocoaPods subspec has been removed. Use the | ||
| `FirebaseFirebaseMLDownloader` subsspec instead. |
There was a problem hiding this comment.
Nit: Firebase/MLModelDownloader is the replacement subspec.
samedson
approved these changes
Apr 19, 2021
ryanwilson
reviewed
Apr 19, 2021
FirebaseCore/CHANGELOG.md
Outdated
| CocoaPod instead. (#7833) | ||
| - [removed] The `Firebase/FirebaseMLModelInterpreter` CocoaPods subspec has been removed. Use the | ||
| `FirebaseFirebaseMLDownloader` subsspec instead. | ||
| `Firebase/FirebaseMLDownloader` subsspec instead. |
There was a problem hiding this comment.
s/FirebaseMLDownloader/MLModelDownloader
firebase-ios-sdk/Firebase.podspec
Line 156 in 5255a22
sab-regime
approved these changes
Apr 19, 2021
sab-regime
approved these changes
Apr 19, 2021
sab-regime
approved these changes
Apr 19, 2021
sab-regime
approved these changes
Apr 19, 2021
ryanwilson
approved these changes
Apr 19, 2021
sab-regime
approved these changes
Apr 19, 2021
sab-regime
approved these changes
Apr 19, 2021
sab-regime
approved these changes
Apr 19, 2021
sab-regime
approved these changes
Apr 19, 2021
sab-regime
approved these changes
Apr 19, 2021
sab-regime
approved these changes
Apr 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7487 and fix #7832
podspec version updates will be done separately using the standard script after 7.11.0 is published