Skip to content

Replace NSCoding with NSSecureCoding #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 5, 2021
Merged

Replace NSCoding with NSSecureCoding #7831

merged 3 commits into from
Apr 5, 2021

Conversation

@charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Apr 2, 2021 •
edited
Loading

Also use GULSecureCoding to encode/decode. This partially fixes #3686.

Tested with previously installed app and fcm token is persisted correctly.

@google-cla google-cla bot added the cla: yes label Apr 2, 2021
@google-oss-bot
Copy link

google-oss-bot commented Apr 2, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    SDK overall coverage changed from 66.01% (0b508f9) to 65.51% (ecfac34) by -0.50%.

    Filename Base (0b508f9) Head (ecfac34) Diff
    FIRMessagingAPNSInfo.m 87.23% 88.00% +0.77%
    FIRMessagingTokenInfo.m 82.78% 77.18% -5.60%
    FIRMessagingTokenManager.m 42.15% 40.60% -1.55%
    FIRMessagingTokenOperation.m 96.84% 95.57% -1.27%
    FIRMessagingTokenStore.m 68.42% 58.93% -9.49%

Test Logs

paulb777
paulb777 approved these changes Apr 5, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@charlotteliang charlotteliang merged commit 34c4bdb into master Apr 5, 2021
@charlotteliang charlotteliang deleted the fm-secure-token branch April 5, 2021 19:55
charlotteliang added a commit that referenced this pull request Apr 8, 2021
@charlotteliang
Revert "Replace NSCoding with NSSecureCoding (#7831)"
843cec5 
This reverts commit 34c4bdb.
@charlotteliang charlotteliang mentioned this pull request Apr 8, 2021
Merged
charlotteliang added a commit that referenced this pull request Apr 8, 2021
@charlotteliang
Revert "Replace NSCoding with NSSecureCoding (#7831)" (#7863)
b245611 
This reverts commit 34c4bdb.
@firebase firebase locked and limited conversation to collaborators May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@maksymmalyhin maksymmalyhin Awaiting requested review from maksymmalyhin

Assignees

No one assigned

Labels

api: messaging cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Various Firebase types does not conform to NSSecureCoding

3 participants

@charlotteliang @google-oss-bot @paulb777