Skip to content

Nightly zip should use SpecsDev #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2021
Merged

Nightly zip should use SpecsDev #7807

merged 1 commit into from
Mar 30, 2021

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Mar 30, 2021

Fix zip failure in #7797

@google-cla google-cla bot added the cla: yes label Mar 30, 2021
@paulb777 paulb777 mentioned this pull request Mar 30, 2021
Closed
ryanwilson
ryanwilson reviewed Mar 30, 2021
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this could affect using the zip for releases, right? Since now SpecsDev could be included in the published zip file which we wouldn't expect. WDYT?

@paulb777
Copy link
Member Author

paulb777 commented Mar 30, 2021

Don't we currently use github.event.inputs.custom_spec_repos for releases?

We would need to split this out when we release from a nightly build.

@paulb777 paulb777 requested a review from ryanwilson March 30, 2021 14:38
@paulb777 paulb777 merged commit a7ada99 into master Mar 30, 2021
@paulb777 paulb777 deleted the pb-nightly-zip branch March 30, 2021 14:51
paulb777 added a commit that referenced this pull request Mar 31, 2021
@paulb777
Revert "Nightly zip should use SpecsDev (#7807)"
a4065e2 
This reverts commit a7ada99.
@paulb777 paulb777 mentioned this pull request Mar 31, 2021
Merged
paulb777 added a commit that referenced this pull request Mar 31, 2021
@paulb777
Revert "Nightly zip should use SpecsDev (#7807)" (#7817)
1e39eb4 
This reverts commit a7ada99.
@firebase firebase locked and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulb777 @ryanwilson