Skip to content

Conversation

@christibbs
Copy link
Contributor

@christibbs christibbs commented Mar 22, 2021

Having trouble including the FIAM package as a local dependency. Shall we check this in for now?

Fixes #7715.

@christibbs christibbs requested a review from paulb777 March 22, 2021 18:09
@google-cla google-cla bot added the cla: yes label Mar 22, 2021
@christibbs
Copy link
Contributor Author

christibbs commented Mar 22, 2021

Actually I should verify that this works end to end since I'm not sure this bundle fetching logic will work given SPM setup:

.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

paulb777
paulb777 previously approved these changes Mar 22, 2021
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me on manual verification, since this does not get tested by CI.

@paulb777 paulb777 dismissed their stale review March 24, 2021 22:57

Resource organization needs work

@ncooke3
Copy link
Member

ncooke3 commented Mar 25, 2021

Closing in favor of #7788

@ncooke3 ncooke3 closed this Mar 25, 2021
@firebase firebase locked and limited conversation to collaborators Apr 25, 2021
@paulb777 paulb777 deleted the fiam-fix-spm branch January 21, 2022 00:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In-App Messaging via SPM missing resource bundle

4 participants