Skip to content

[IID removal]Move Checkin unit tests from InstanceID to Messaging #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 1, 2021
Merged

[IID removal]Move Checkin unit tests from InstanceID to Messaging #7603

merged 14 commits into from
Mar 1, 2021

Conversation

@charlotteliang
Copy link
Contributor

@charlotteliang charlotteliang commented Feb 24, 2021 •
edited
Loading

Move the following unit tests to Messaging:
AuthServiceTest
BackupExcludedPlistTest
CheckinPreferencesTest
CheckinServiceTest
CheckinStoreTest

Also update a few header files that were merged from master to the refactor branch.
#no-changelog

@google-cla google-cla bot added the cla: yes label Feb 24, 2021
@google-oss-bot
Copy link

google-oss-bot commented Feb 24, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseMessaging-iOS-FirebaseMessaging.framework

    SDK overall coverage changed from 62.08% (a150769) to 56.92% (bdece48) by -5.17%.

    Click to show coverage changes in 21 files.
    Filename Base (a150769) Head (bdece48) Diff
    FIRMessaging.m 68.63% 51.26% -17.36%
    FIRMessagingAPNSInfo.m ? 36.17% ?
    FIRMessagingAuthKeychain.m ? 88.64% ?
    FIRMessagingAuthService.m ? 86.67% ?
    FIRMessagingBackupExcludedPlist.m ? 86.30% ?
    FIRMessagingCheckinPreferences.m ? 98.18% ?
    FIRMessagingCheckinService.m ? 88.24% ?
    FIRMessagingCheckinStore.m ? 72.48% ?
    FIRMessagingKeychain.m ? 93.89% ?
    FIRMessagingPendingTopicsList.m 90.65% 89.93% -0.72%
    FIRMessagingPubSub.m 53.01% 53.85% +0.83%
    FIRMessagingRemoteNotificationsProxy.m 62.97% 73.64% +10.67%
    FIRMessagingRmqManager.m 58.95% 58.57% -0.38%
    FIRMessagingSyncMessageManager.m 76.92% 73.08% -3.85%
    FIRMessagingTokenDeleteOperation.m ? 0.00% ?
    FIRMessagingTokenFetchOperation.m ? 5.19% ?
    FIRMessagingTokenInfo.m ? 41.06% ?
    FIRMessagingTokenManager.m ? 32.85% ?
    FIRMessagingTokenOperation.m ? 48.10% ?
    FIRMessagingTokenStore.m ? 19.47% ?
    FIRMessagingUtilities.m 44.23% 50.14% +5.91%

Test Logs

@charlotteliang charlotteliang changed the title [IID removal][draft] [IID removal]Move Checkin unit tests from InstanceID to Messaging Feb 25, 2021
@paulb777
Copy link
Member

paulb777 commented Feb 25, 2021

Please fix CI

maksymmalyhin
maksymmalyhin reviewed Feb 25, 2021
View reviewed changes
Copy link
Contributor

@maksymmalyhin maksymmalyhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but a couple minor questions/comments mostly around test improvements.

paulb777
paulb777 approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

FirebaseMessaging/Tests/UnitTests/FIRMessagingAuthKeychainTest.m
#import <TargetConditionals.h>
#if !TARGET_OS_MACCATALYST && !TARGET_OS_IOS
// Skip keychain tests on Catalyst and iOS
#if !TARGET_OS_MACCATALYST && !SWIFT_PACKAGE
Copy link
Member

@paulb777 paulb777 Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is MacOS ok now? I suspect this should be iOS, tvOS and not Catalyst, not macOS, not Swift Package.

Copy link
Contributor Author

@charlotteliang charlotteliang Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this builds on non swift package, when use swift package, it failed at least for iOS and tvOS locally. I'm guessing CI wasn't running tvOS that's why it was passing for previous change.

@charlotteliang charlotteliang merged commit 41877bd into chen/fm-master Mar 1, 2021
@charlotteliang charlotteliang deleted the chen/fm-spm-test branch March 1, 2021 19:24
@firebase firebase locked and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

+1 more reviewer

@maksymmalyhin maksymmalyhin maksymmalyhin left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: messaging cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charlotteliang @google-oss-bot @paulb777 @maksymmalyhin