Move the dispatch of gauge metric calls to its dedicated thread asynchronously #7601
Conversation
visumickey
requested review from
jeremyjiang-dev,
maksymmalyhin,
paulb777 and
ramanpreetSinghKhinda
Coverage ReportAffected SDKs
Test Logs
|
| [self prepareAndDispatchGaugeData]; | ||
| }); | ||
| // Dispatch the already available gauge data with old sessionId. | ||
| [self prepareAndDispatchCollectedGaugeDataWithSessionId:self.currentSessionId]; |
There was a problem hiding this comment.
May it happen that the new session gauge data will be associated with the old session ID? Looks like not, because addGaugeData is also protected by the serial queue. But would like to check with you just in case.
There was a problem hiding this comment.
That is a good question as well. I thought about as well, a lot in detail. The ideal solution I had in my mind was to make the prepareAndDispatch method to take both the gauge data and the session ID as inputs (making it more self-contained). But that lead to a lot of repetitive code in reseting the gauge data unprotected. So took this approach which has the risk you mentioned, but since both addGaugeData and prepareAndDispatch happen on the same serial queue, that issue would not happen.
5 participants
Fixes #7535