Skip to content

Completely stop forcing static frameworks #7570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 22, 2021
Merged

Completely stop forcing static frameworks #7570

merged 5 commits into from
Feb 22, 2021

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Feb 19, 2021 •
edited
Loading

Follow up fix for #6557 for Performance, MLModelDownloader, and Segmentation, that were not yet on master when the original 7.0.0 update was made.

Also fix exposed Catalyst build problem with mobile connectivity header.

Fix #7569

@google-cla google-cla bot added the cla: yes label Feb 19, 2021
@paulb777 paulb777 added this to the 7.8.0 - M91 milestone Feb 19, 2021
@google-oss-bot
Copy link

google-oss-bot commented Feb 19, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebasePerformance-iOS-FirebasePerformance.framework

    SDK overall coverage changed from 88.01% (36303b4) to 88.04% (4a379cb) by +0.03%.

    Filename Base (36303b4) Head (4a379cb) Diff
    FPRNSURLSessionDelegateInstrument.m 98.03% 98.69% +0.66%

Test Logs

visumickey
visumickey reviewed Feb 22, 2021
View reviewed changes
@paulb777 paulb777 merged commit 38a056f into master Feb 22, 2021
@paulb777 paulb777 deleted the pb-perf-dyn branch February 22, 2021 19:20
@paulb777 paulb777 mentioned this pull request Feb 22, 2021
Closed
ziadtamim pushed a commit to ziadtamim/firebase-ios-sdk that referenced this pull request Mar 11, 2021
@paulb777 @ziadtamim
Completely stop forcing static frameworks (firebase#7570)
86a9255
@firebase firebase locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@visumickey visumickey visumickey approved these changes

+1 more reviewer

@ariel-demarco-peya ariel-demarco-peya ariel-demarco-peya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@visumickey visumickey

Labels

api: performance cla: yes

Projects

None yet

Milestone

7.8.0 - M91

Development

Successfully merging this pull request may close these issues.

5 participants

@paulb777 @google-oss-bot @ryanwilson @visumickey @ariel-demarco-peya