Skip to content

RTDB FSRWebSocket: suppress diagnostic error #7460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2021
Merged

RTDB FSRWebSocket: suppress diagnostic error #7460

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4f94bb4
RTDB FSRWebSocket: suppress diagnostic error
maksymmalyhin Feb 4, 2021
49b8449
Use macro instead of a constant
maksymmalyhin Feb 4, 2021
410e539
Changelog
maksymmalyhin Feb 4, 2021
8ea0dcb
typo
maksymmalyhin Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions FirebaseDatabase/Sources/third_party/SocketRocket/FSRWebSocket.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,19 +1559,21 @@ - (void)safeHandleEvent:(NSStreamEvent)eventCode stream:(NSStream *)aStream

case NSStreamEventHasBytesAvailable: {
SRFastLog(@"NSStreamEventHasBytesAvailable %@", aStream);
const NSUInteger bufferSize = 2048;
uint8_t buffer[bufferSize];

#define FSRWEB_SOCKET_BUFFER_SIZE 2048
uint8_t buffer[FSRWEB_SOCKET_BUFFER_SIZE];


while (_inputStream.hasBytesAvailable) {
NSInteger bytes_read = [_inputStream read:buffer maxLength:bufferSize];
NSInteger bytes_read = [_inputStream read:buffer maxLength:FSRWEB_SOCKET_BUFFER_SIZE];

if (bytes_read > 0) {
[_readBuffer appendBytes:buffer length:bytes_read];
} else if (bytes_read < 0) {
[self _failWithError:_inputStream.streamError];
}

if (bytes_read != bufferSize) {
if (bytes_read != FSRWEB_SOCKET_BUFFER_SIZE) {
break;
}
};
Expand Down