Skip to content

Performance Improvements - Move Some Initialization Work to a Background Thread #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 20, 2021
Merged

Performance Improvements - Move Some Initialization Work to a Background Thread #7332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70edbea
Performance Improvements
elenadoty Jan 20, 2021
f55bce7
changelog
elenadoty Jan 20, 2021
c06d2c9
Update CHANGELOG.md
elenadoty Jan 20, 2021
82d9cfa
Merge branch 'master' into images_at_crash
elenadoty Jan 20, 2021
a6438d2
Update CHANGELOG.md
elenadoty Jan 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Crashlytics/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Unreleased
- [changed] Improve start-up performance by moving some initialization work to a background thread (#7332).
- [changed] Updated upload-symbols to a version that is notarized to avoid macOS security alerts (#7323).

# v7.4.0
Expand Down
19 changes: 9 additions & 10 deletions Crashlytics/Crashlytics/Components/FIRCLSBinaryImage.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,19 +364,18 @@ static void FIRCLSBinaryImageChanged(bool added,
intptr_t vmaddr_slide) {
// FIRCLSSDKLog("Binary image %s %p\n", added ? "loaded" : "unloaded", mh);

FIRCLSBinaryImageDetails imageDetails;

memset(&imageDetails, 0, sizeof(FIRCLSBinaryImageDetails));
// this isn't, so do it on a serial queue
dispatch_async(FIRCLSGetBinaryImageQueue(), ^{
FIRCLSBinaryImageDetails imageDetails;

imageDetails.slice = FIRCLSMachOSliceWithHeader((void*)mh);
imageDetails.vmaddr_slide = vmaddr_slide;
FIRCLSBinaryImageFillInImageDetails(&imageDetails);
memset(&imageDetails, 0, sizeof(FIRCLSBinaryImageDetails));

// this is an atomic operation
FIRCLSBinaryImageStoreNode(added, imageDetails);
imageDetails.slice = FIRCLSMachOSliceWithHeader((void*)mh);
imageDetails.vmaddr_slide = vmaddr_slide;
FIRCLSBinaryImageFillInImageDetails(&imageDetails);

// this isn't, so do it on a serial queue
dispatch_async(FIRCLSGetBinaryImageQueue(), ^{
// this is an atomic operation
FIRCLSBinaryImageStoreNode(added, imageDetails);
FIRCLSBinaryImageRecordSlice(added, imageDetails);
});
}
Expand Down