Track conversions on in-app message campaigns without a clickthrough URL #7306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e an action URL. Do this at impression time. (Initial implementation commit)
…cleaner code all-around
prakhar1989
reviewed
Jan 14, 2021
paulb777
approved these changes
Jan 14, 2021
prakhar1989
reviewed
Jan 15, 2021
| } | ||
| } | ||
|
|
||
| - (BOOL)shouldTrackConversionsOnImpressionForCurrentInAppMessage: |
There was a problem hiding this comment.
Shouldn't this also include that the message should have conversion event defined?
If it doesn't we don't need to track it.
There was a problem hiding this comment.
We weren't checking on a conversion event previously, from comments (and piecing together the code) it looks like we currently always track the conversion and then presumably handle reporting on the backend. Do you think we need to check for this now?
There was a problem hiding this comment.
We're waiting on Analytics to confirm how to proceed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conversion tracking wasn't working for campaigns with no click-through URL. This change tracks conversions on these campaigns when the message is shown.