[Remove IID] Move some token unit tests from IID to Messaging #7294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
charlotteliang
changed the title
charlotteliang
requested review from
gsakakihara,
maksymmalyhin and
paulb777
maksymmalyhin
approved these changes
Feb 11, 2021
| #import "FirebaseMessaging/Sources/FIRMessagingUtilities.h" | ||
| #import "FirebaseMessaging/Sources/NSError+FIRMessaging.h" | ||
| #import "FirebaseMessaging/Sources/Token/FIRMessagingAuthKeyChain.h" | ||
| #import "FirebaseMessaging/Sources/Token/FIRMessagingAuthKeychain.h" |
There was a problem hiding this comment.
I'm curious if using GULKeychainUtils instead of FIRMessagingAuthKeychain may save some extra code and tests?
There was a problem hiding this comment.
Good call. I will take a look at.
There was a problem hiding this comment.
Let me know if you need any help with that.
There was a problem hiding this comment.
yeah maybe we should work on separate PR. Feel free to checkin in chen/fm-master while I keep adding more unit tests.
…e the latest setup from master
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving a few unit tests from InstanceID to Messaging after the refactor.
Simplify some init methods as there's no need to inject some classes as they can be initialized inside.
Also since we updated clang-format so there are a few nonmessaging methods are formatted in the branch.