Skip to content

Verify that @DocumentID works with custom Codable methods. #7247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2021
Merged

Verify that @DocumentID works with custom Codable methods. #7247

merged 2 commits into from
Jan 5, 2021

Conversation

@wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jan 5, 2021 •
edited
Loading

Prompted by #7242.

This shows that property wrappers like @DocumentID can be used in custom Codable methods, and produce results essentially identical to testSelfDocumentID.

#no-changelog

@wilhuff wilhuff requested a review from thebrianchen January 5, 2021 20:28
@google-cla google-cla bot added the cla: yes label Jan 5, 2021
@wilhuff wilhuff mentioned this pull request Jan 5, 2021
Closed
@wilhuff wilhuff force-pushed the wilhuff/document-id-custom-methods branch from cfa4e23 to 88ecc3c Compare January 5, 2021 21:17
thebrianchen
thebrianchen approved these changes Jan 5, 2021
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for taking over this one + the detailed explanation!

@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Jan 5, 2021
@wilhuff wilhuff merged commit b34f9f2 into master Jan 5, 2021
@wilhuff wilhuff deleted the wilhuff/document-id-custom-methods branch January 5, 2021 22:33
@peterfriese peterfriese mentioned this pull request Jan 27, 2021
Closed
@firebase firebase locked and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@thebrianchen thebrianchen thebrianchen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wilhuff wilhuff

Labels

api: firestore cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wilhuff @thebrianchen