Add catalyst #7192
Merged
Add catalyst #7192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
reviewed
Dec 17, 2020
| spm-cron: | ||
| # Don't run on private repo. | ||
| if: github.event_name == 'schedule' && github.repository != 'FirebasePrivate/firebase-ios-sdk' | ||
| runs-on: macOS-latest |
There was a problem hiding this comment.
Temporarily comment line 51 to test the spm-cron job before tonight.
| if: github.repository != 'FirebasePrivate/firebase-ios-sdk' || github.event_name == 'pull_request' | ||
| runs-on: macOS-latest | ||
| steps: | ||
| - uses: actions/checkout@v2 |
There was a problem hiding this comment.
Change the build on line 74 to test to also run tests
There was a problem hiding this comment.
I made this change, but my integration tests are failing. Am I missing the GoogleService-Info.plist under catalyst?
There was a problem hiding this comment.
Usually a GoogleService-Info.plist isn't needed for unit tests. It looks like the scheme needs to be specified - like https://github.com/firebase/firebase-ios-sdk/blob/master/.github/workflows/core.yml#L70
There was a problem hiding this comment.
Ah perfect, thanks!
paulb777
approved these changes
Dec 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
If not, go file an issue about this before creating a pull request to discuss.
Testing
API Changes
us make Firebase APIs better, please propose your change in a feature request so that we
can discuss it together.