Use initWithFrame: to create the in-app message window in non-UIScene apps #7080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the in-app message window
paulb777
reviewed
Dec 2, 2020
| UIWindowScene *foregroundedScene = [[self class] foregroundedScene]; | ||
| UIWindowForBanner = [[FIRIAMBannerViewUIWindow alloc] initWithWindowScene:foregroundedScene]; | ||
| if (foregroundedScene.delegate) { | ||
| UIWindowForBanner = [[UIWindow alloc] initWithWindowScene:foregroundedScene]; |
There was a problem hiding this comment.
Should this be FIRIAMBannerViewUIWindow instead of UIWindow?
Even better would be to refactor to get rid of the duplicated code.
There was a problem hiding this comment.
Fixed both in 14c31bb.
paulb777
approved these changes
Dec 3, 2020
FirebaseInAppMessaging/CHANGELOG.md
Outdated
| @@ -1,3 +1,6 @@ | |||
| # 2020-10 -- v7.3.0 | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These UIWindow factory methods aren't going to win any beauty contests but this should fix #6803