Skip to content

clarify error when logging settings failures #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2020
Merged

clarify error when logging settings failures #6847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b1c402
clarify error when logging settings failures
adamvduke Oct 27, 2020
ab0adb4
update Crashlytics/CHANGELOG.md for #6847
adamvduke Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Crashlytics/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased
- [fixed] Fixed an issue where symbol uploads would fail when there are spaces in the project path, particularly in Unity builds (#6789).
- [changed] Added additional logging when settings requests fail with a 404 status to help customers debug onboarding issues (#6847).

# v4.6.2

Expand Down
10 changes: 9 additions & 1 deletion Crashlytics/Crashlytics/Settings/FIRCLSSettingsOnboardingManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,15 @@ - (void)onboardingOperation:(FIRCLSOnboardingOperation *)operation
- (void)operation:(FIRCLSDownloadAndSaveSettingsOperation *)operation
didDownloadAndSaveSettingsWithError:(nullable NSError *)error {
if (error) {
FIRCLSErrorLog(@"Failed to download settings %@", error);
NSString *message = @"Failed to download settings.";
if (error.userInfo && [error.userInfo objectForKey:@"status_code"] &&
[[error.userInfo objectForKey:@"status_code"]
isEqualToNumber:[NSNumber numberWithInt:404]]) {
NSString *debugHint = @"If this is your first time launching the app, make sure you have "
@"enabled Crashlytics in the Firebase Console.";
message = [NSString stringWithFormat:@"%@ %@", message, debugHint];
}
FIRCLSErrorLog(@"%@ %@", message, error);
[self finishNetworkingSession];
return;
}
Expand Down