Skip to content

Crashlytics update run script to quote all arguments passed #6789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 20, 2020
Merged

Crashlytics update run script to quote all arguments passed #6789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3b530b4
Update run script to quote all arguments passed
samedson Oct 20, 2020
97ca02d
Quote args
samedson Oct 20, 2020
d3fa3d3
Comment
samedson Oct 20, 2020
bfdbeab
CHANGELOG
samedson Oct 20, 2020
43be189
CHANGELOG better
samedson Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Crashlytics/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Unreleased
- [fixed] Fixed an issue where symbol uploads would fail when there are spaces in the project path, particularly in Unity builds (#6789).

# v4.6.2

- [changed] Improved upload-symbols conversion speed. Customers with large dSYMs should see a significant improvement in the time it takes to upload Crashlytics symbols.
Expand Down
16 changes: 6 additions & 10 deletions Crashlytics/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,17 +39,13 @@
# Figure out where we're being called from
DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )

# If the first argument is specified without a dash, treat it as the Fabric API
# Key and add it as an argument.
if [ -z "$1" ] || [[ $1 == -* ]]; then
API_KEY_ARG=""
else
API_KEY_ARG="-a $1"; shift
fi
# Build up the arguments list, passing through any flags added, and quoting
# every argument in case there are spaces in any of the the paths.
ARGUMENTS=''
for i in "$@"; do
ARGUMENTS="$ARGUMENTS \"$i\""
done

# Build up the arguments list, passing through any flags added after the
# API Key
ARGUMENTS="$API_KEY_ARG $@"
VALIDATE_ARGUMENTS="$ARGUMENTS --build-phase --validate"
UPLOAD_ARGUMENTS="$ARGUMENTS --build-phase"

Expand Down