Skip to content

Add Info.plist to Carthage binary frameworks #6445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2020
Merged

Add Info.plist to Carthage binary frameworks #6445

merged 2 commits into from
Sep 11, 2020

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Sep 11, 2020

Fix #5562

Tested in #6444 and

 $ diff -r ~/zip-m77/2020-08-05T09-21-45/CarthageFirebase/ CarthageFirebase/ | grep "Only in"
Only in CarthageFirebase/FirebaseAnalytics/FIRAnalyticsConnector.framework: Info.plist
Only in CarthageFirebase/FirebaseAnalytics/FirebaseAnalytics.framework: Info.plist
Only in CarthageFirebase/FirebaseAnalytics/GoogleAppMeasurement.framework: Info.plist
Only in CarthageFirebase/: FirebaseAppDistribution
Only in CarthageFirebase/FirebaseMLModelInterpreter/FirebaseMLCommon.framework: Info.plist
Only in CarthageFirebase/FirebaseMLModelInterpreter/FirebaseMLModelInterpreter.framework: Info.plist
Only in CarthageFirebase/FirebaseMLModelInterpreter/TensorFlowLiteC.framework: Info.plist
Only in CarthageFirebase/FirebaseMLVision/FirebaseMLCommon.framework: Info.plist
Only in CarthageFirebase/FirebaseMLVision/FirebaseMLVision.framework: Info.plist
Only in CarthageFirebase/FirebasePerformance/FirebasePerformance.framework: Info.plist
Only in CarthageFirebase/Google-Mobile-Ads-SDK/GoogleMobileAds.framework: Info.plist
Only in CarthageFirebase/Google-Mobile-Ads-SDK: UserMessagingPlatform.framework
Only in CarthageFirebase/GoogleSignIn/GoogleSignIn.framework: Info.plist

@paulb777 paulb777 added zip-builder Tools related to building the zip file. Carthage labels Sep 11, 2020
@paulb777 paulb777 requested a review from ryanwilson September 11, 2020 19:11
@paulb777 paulb777 added this to the 6.33.0 - М80 milestone Sep 11, 2020
@paulb777 paulb777 merged commit c0130d8 into master Sep 11, 2020
@paulb777 paulb777 deleted the pb-zip-plist branch September 11, 2020 20:14
@firebase firebase locked and limited conversation to collaborators Oct 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees

No one assigned

Labels

api: core Carthage cla: yes zip-builder Tools related to building the zip file.

Projects

None yet

Milestone

6.33.0 - М80

Development

Successfully merging this pull request may close these issues.

[Carthage] Some frameworks are missing Info.plist files and fail installation in Simulator

4 participants

@paulb777 @ryanwilson @googlebot @google-oss-bot