Skip to content

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Aug 27, 2020

Fixes #6340

#no-changelog

Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

#include "grpcpp/create_channel.h"

SUPPRESS_DOCUMENTATION_WARNINGS_BEGIN()
#include "grpcpp/grpcpp.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well just surround all the grpcpp includes in the block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@wilhuff wilhuff assigned dconeybe and unassigned wilhuff Aug 27, 2020
@dconeybe dconeybe merged commit 95add7f into master Aug 27, 2020
@dconeybe dconeybe deleted the dconeybe/FixGrpcDocWarning branch August 27, 2020 20:30
@firebase firebase locked and limited conversation to collaborators Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation Issue: Parameter 'selected_port[out]' not found in the function declaration 6.31.0

4 participants