Skip to content

App distribution add bundle header #6346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 27, 2020
Merged

App distribution add bundle header #6346

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59e6b32
Add x-ios-bundle-identifier to list releases for restricted api keys
schnecle Aug 26, 2020
1891cc5
Update changelog
schnecle Aug 27, 2020
ad869f3
Terminate changelog statements with periods
schnecle Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FirebaseAppDistribution/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# Unreleased
- [changed] Updated header comments (#6321).
- [fixed] Bug for customers with restricted api keys unable to fetch releases

# v0.9.0
- Initial beta release.
2 changes: 2 additions & 0 deletions FirebaseAppDistribution/Sources/FIRFADApiService.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
@"-/testerApps/%@/installations/%@/releases";
NSString *const kInstallationAuthHeader = @"X-Goog-Firebase-Installations-Auth";
NSString *const kApiHeaderKey = @"X-Goog-Api-Key";
NSString *const kApiBundleKey = @"X-Ios-Bundle-Identifier";
NSString *const kResponseReleasesKey = @"releases";

@implementation FIRFADApiService
Expand Down Expand Up @@ -73,6 +74,7 @@ + (NSMutableURLRequest *)createHTTPRequest:(NSString *)method
[request setHTTPMethod:method];
[request setValue:authTokenResult.authToken forHTTPHeaderField:kInstallationAuthHeader];
[request setValue:[[FIRApp defaultApp] options].APIKey forHTTPHeaderField:kApiHeaderKey];
[request setValue:[NSBundle mainBundle].bundleIdentifier forHTTPHeaderField:kApiBundleKey];
return request;
}

Expand Down