Add both IID and FCM APIs in test app to test compatibility #6285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
paulb777
reviewed
Aug 18, 2020
| * @param completion The completion handler to handle the token request. | ||
| */ | ||
|
|
||
| - (void)tokenWithCompletion: |
There was a problem hiding this comment.
Did the new public APIs get reviewed?
There was a problem hiding this comment.
not yet, I realize this could be pushed to master early than API review. I've removed the new public API and use the existing token API for test app testing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to update the cache in Messaging as IID already update its own cache and storage that is shared between messaging and IID, so we just have to update messaging's cache.