Skip to content

Messaging - no typedefs in public APIs #6278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Messaging - no typedefs in public APIs #6278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
362bb08
Messaging - no typedefs in public APIs
paulb777 Aug 14, 2020
32dbba8
nonnull by default
paulb777 Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FirebaseMessaging/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# unreleased
- [fixed] Fixed an issue that topic doesn't work in watchOS. (#6160)
- [fixed] Improved Xcode completion of public API completion handlers in Swift. (#6278)

# 2020-07 -- v4.6.1
- [changed] Remove logic that is executed for iOS 7 and below. (#5835)
Expand Down
9 changes: 5 additions & 4 deletions FirebaseMessaging/Sources/Public/FIRMessaging.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,8 @@ NS_SWIFT_NAME(Messaging)
* @param completion The completion handler to handle the token request.
*/
- (void)retrieveFCMTokenForSenderID:(NSString *)senderID
completion:(FIRMessagingFCMTokenFetchCompletion)completion
completion:(void (^)(NSString *_Nullable FCMToken,
NSError *_Nullable error))completion
NS_SWIFT_NAME(retrieveFCMToken(forSenderID:completion:));

/**
Expand All @@ -407,7 +408,7 @@ NS_SWIFT_NAME(Messaging)
* @param completion The completion handler to handle the token deletion.
*/
- (void)deleteFCMTokenForSenderID:(NSString *)senderID
completion:(FIRMessagingDeleteFCMTokenCompletion)completion
completion:(void (^)(NSError *_Nullable error))completion
NS_SWIFT_NAME(deleteFCMToken(forSenderID:completion:));

#pragma mark - Topics
Expand All @@ -432,7 +433,7 @@ NS_SWIFT_NAME(Messaging)
* appropriate error object is returned.
*/
- (void)subscribeToTopic:(nonnull NSString *)topic
completion:(nullable FIRMessagingTopicOperationCompletion)completion;
completion:(void (^_Nullable)(NSError *_Nullable error))completion;

/**
* Asynchronously unsubscribe from a topic. This uses a FCM Token
Expand All @@ -454,7 +455,7 @@ NS_SWIFT_NAME(Messaging)
* appropriate error object is returned.
*/
- (void)unsubscribeFromTopic:(nonnull NSString *)topic
completion:(nullable FIRMessagingTopicOperationCompletion)completion;
completion:(void (^_Nullable)(NSError *_Nullable error))completion;

#pragma mark - Upstream

Expand Down