Separate Core private versus internal headers #5759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
maksymmalyhin
approved these changes
Jun 8, 2020
ryanwilson
approved these changes
Jun 8, 2020
| #import "FirebaseCore/Tests/Unit/FIRTestCase.h" | ||
|
|
||
| #import <FirebaseCore/FIRAnalyticsConfiguration.h> | ||
| #import "FirebaseCore/Sources/FIRAnalyticsConfiguration.h" |
There was a problem hiding this comment.
May be a silly question but just to confirm for here and other tests - is it alright that we're not using framework imports in test code?
There was a problem hiding this comment.
Yes. The tests are in the repo and using repo-relative imports should allow Swift Package Manager to build them without change. We should leave framework import testing for integration tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the reorganization part of #3777.
Based on testing in #5758, move Core headers only used by Core from "Private" to "Sources".