Skip to content

FIS: disable Auth token auto fetch #5656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2020
Merged

FIS: disable Auth token auto fetch #5656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1cd7458
FIS: disable Auth token auto fetch
maksymmalyhin May 20, 2020
c360b4e
Punctuation
maksymmalyhin May 20, 2020
77782c9
Merge branch 'master' into mm/fis-auto
maksymmalyhin May 20, 2020
f519112
Changelog
maksymmalyhin May 20, 2020
36724a5
Don't fail tests when no default app was created
maksymmalyhin May 20, 2020
411deda
style
maksymmalyhin May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FirebaseInstallations/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
NOTE: Installation Identifiers created by previous versions will be reset on Mac OS which can affect e.g. A/B Testing variants or debug device targeting for Firebase Messaging.
iOS, TVOS and watchOS Installation Identifiers will not be affected. (#5603)
- [changed] More readable server error console messages. (#5654)
- [changed] Auth Token auto fetch disabled. (#5656)

# v1.2.0 -- M69

Expand Down
4 changes: 3 additions & 1 deletion FirebaseInstallations/Source/Library/FIRInstallations.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,12 @@ - (instancetype)initWitAppOptions:(FIROptions *)appOptions appName:(NSString *)a
projectID:appOptions.projectID
GCMSenderID:appOptions.GCMSenderID
accessGroup:appOptions.appGroupID];

// `prefetchAuthToken` is disabled due to b/156746574.
return [self initWithAppOptions:appOptions
appName:appName
installationsIDController:IDController
prefetchAuthToken:YES];
prefetchAuthToken:NO];
}

/// The initializer is supposed to be used by tests to inject `installationsStore`.
Expand Down
3 changes: 1 addition & 2 deletions FirebaseInstallations/Source/Tests/Integration/FIRInstallationsIntegrationTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@ - (void)setUp {

- (void)tearDown {
// Delete the installation.
[self.installations deleteWithCompletion:^(NSError *_Nullable error) {
XCTAssertNil(error);
[self.installations deleteWithCompletion:^(NSError *_Nullable error){
}];

// Wait for any pending background job to be completed.
Expand Down