Remove unused source file #5639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
commented
May 19, 2020
|
|
||
| base_dir = "FirebaseRemoteConfig/Sources/" | ||
| s.source_files = base_dir + '**/*.[mh]' | ||
| s.requires_arc = base_dir + '*.m' |
There was a problem hiding this comment.
This flag indicates that the other files should use arc. Removing the flag indicates all files follow the default of building with arc.
charlotteliang
approved these changes
May 19, 2020
|
Going to merge this one now. If there's additional feedback, I'll address in a subsequent PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a discussion with @chliangGoogle, we realized that RemoteConfig no longer uses its own protos. It only uses protos from ABTesting. This PR removes the unused source and has the side effect of fixing #4334.
Fix #4334