Skip to content

Only log the URL follow event in messageClicked:withAction: if there's a URL to follow #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2020
Merged

Only log the URL follow event in messageClicked:withAction: if there's a URL to follow #5564

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e1af5a
Only log the URL follow event in messageClicked:withAction: if there'…
christibbs May 11, 2020
8d26898
Add test case for empty action URL
christibbs May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions FirebaseInAppMessaging/Sources/Flows/FIRIAMDisplayExecutor.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,18 @@ - (void)messageClicked:(FIRInAppMessagingDisplayMessage *)inAppMessage
[self recordValidImpression:_currentMsgBeingDisplayed.renderData.messageID
withMessageName:_currentMsgBeingDisplayed.renderData.name];

[self.analyticsEventLogger
logAnalyticsEventForType:FIRIAMAnalyticsEventActionURLFollow
forCampaignID:_currentMsgBeingDisplayed.renderData.messageID
withCampaignName:_currentMsgBeingDisplayed.renderData.name
eventTimeInMs:nil
completion:^(BOOL success) {
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM400032",
@"Logging analytics event for url following %@",
success ? @"succeeded" : @"failed");
}];
if (action.actionURL) {
[self.analyticsEventLogger
logAnalyticsEventForType:FIRIAMAnalyticsEventActionURLFollow
forCampaignID:_currentMsgBeingDisplayed.renderData.messageID
withCampaignName:_currentMsgBeingDisplayed.renderData.name
eventTimeInMs:nil
completion:^(BOOL success) {
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM400032",
@"Logging analytics event for url following %@",
success ? @"succeeded" : @"failed");
}];
}
}

NSURL *actionURL = action.actionURL;
Expand Down
6 changes: 5 additions & 1 deletion FirebaseInAppMessaging/Tests/Unit/FIRIAMDisplayExecutorTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,8 +599,12 @@ - (void)testAnalyticsTrackingOnMessageClickCase {

[self.clientMessageCache setMessageData:@[ self.m2 ]];

FIRInAppMessagingAction *m2Action = [[FIRInAppMessagingAction alloc]
initWithActionText:self.m2.renderData.contentData.actionButtonText
actionURL:self.m2.renderData.contentData.actionURL];
FIRIAMMessageDisplayForTesting *display = [[FIRIAMMessageDisplayForTesting alloc]
initWithDelegateInteraction:FIRInAppMessagingDelegateInteractionClick];
initWithDelegateInteraction:FIRInAppMessagingDelegateInteractionClick
action:m2Action];
self.displayExecutor.messageDisplayComponent = display;

[self.displayExecutor checkAndDisplayNextAppForegroundMessage];
Expand Down