Skip to content

Fix UB in defaults loading #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 28, 2020
Merged

Fix UB in defaults loading #5456

merged 3 commits into from
Apr 28, 2020

Conversation

@morganchen12
Copy link
Contributor

@morganchen12 morganchen12 commented Apr 24, 2020

Fixes #5454.

@morganchen12 morganchen12 requested a review from samedson April 24, 2020 18:11
@paulb777 paulb777 added this to the M70 milestone Apr 28, 2020
samedson
samedson approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added one more definition

@morganchen12 morganchen12 merged commit a3ef9f0 into master Apr 28, 2020
@morganchen12 morganchen12 deleted the morganchen/crash branch April 28, 2020 23:09
@firebase firebase locked and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@samedson samedson samedson approved these changes

Assignees

@samedson samedson

Labels

api: crashlytics cla: yes

Projects

None yet

Milestone

6.24.0 - M70

Development

Successfully merging this pull request may close these issues.

Undefined behaviour in loadDefaults in FIRCLSUserDefaults.m

5 participants

@morganchen12 @paulb777 @samedson @googlebot @google-oss-bot