Three ZipBuilder Fixes #5341
Merged
Three ZipBuilder Fixes #5341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
Apr 10, 2020
| podVersion = version | ||
| } else { | ||
| // See if there's a version on the base pod. | ||
| let basePod = String($0.split(separator: "/")[0]) |
There was a problem hiding this comment.
Is it possible for this to out-of-index for dependencies that aren't subspecs, e.g. nanopb?
There was a problem hiding this comment.
My understanding of split is there will always be a 0th element for a non-nil string.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last night's zip build cron job failed because of a bug exposed by #5329 updating the
GoogleUtilitiesversion locally. We were getting the podspec name from the podname without truncating subspec's from the podname.Also fixed a warning from
pod installif a subspec install was requested without a version along with a request to install the base spec with a version.I also added a check to only allow
-buildDependencies falseoption when-zipPodsis used since it does not make sense (nor work) for Firebase product builds.