Skip to content

add missing return when delete token handler is nil #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2020
Merged

add missing return when delete token handler is nil #5247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e27dac
add missing return when delete token handler is nil
charlotteliang Apr 1, 2020
d237b7b
update changelog
charlotteliang Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Firebase/InstanceID/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# 2020-03 -- 4.3.3
- [fixed] Fixed provisioning profile location for catalyst. (#5048)
- [fixed] Fixed crash when passing a nil handler to deleteToken request. (#5247)
- [changed] Remove obsolete logic to improve performance and reduce keychain operations. (#5211, #5237)

# 2020-02 -- 4.3.2
Expand Down
1 change: 1 addition & 0 deletions Firebase/InstanceID/FIRInstanceID.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ - (void)deleteTokenWithAuthorizedEntity:(NSString *)authorizedEntity
if (!handler) {
FIRInstanceIDLoggerError(kFIRInstanceIDMessageCodeInstanceID001,
kFIRInstanceIDInvalidNilHandlerError);
return;
Copy link
Member

@ryanwilson ryanwilson Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to delete the token if there's no completion handler, or leave it as is?

Copy link
Contributor Author

@charlotteliang charlotteliang Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the API interface says it is nonnull here so it is supposed to return if passing anil.

}

// comparing enums to ints directly throws a warning
Expand Down