Only delete events when package was successfully delivered #5172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a unit test and confirmed that the test fails without the changes I made. |
samedson
approved these changes
Mar 23, 2020
paulb777
approved these changes
Mar 23, 2020
mikehaney24
added a commit
that referenced
this pull request
Mar 23, 2020
* Only delete events when package was successfully delivered * Add unit test to check that retrying a package delivery doesn't delete an event file
mikehaney24
added a commit
that referenced
this pull request
Mar 23, 2020
paulb777
added a commit
that referenced
this pull request
Mar 24, 2020
* Update versions for Release 6.21.0 * Libraries should save state if a completion block is requested (#5147) (#5148) * Libraries should save state if a completion block is requested Currently, the onComplete block of sendXEvent:onComplete: is invoked when the event bytes are written to disk. However, if the app crashes before a lifecycle event occurs (trigger GDTCORStorage to serialize to disk), that event if effectively lost because the metadata has all been lost. This change triggers the saving of state of GDTCORStorage and prioritizers (if they implement it) if an onComplete block has been given. * Remove RC from M67 (#5157) * Revert "Migrate from using IID SDK for Remote Config to the new FIS SDK (#5096)" (#5156) (#5159) This reverts commit 887ff82. * Only delete events when package was successfully delivered (#5172) (#5173) * Only delete events when package was successfully delivered * Add unit test to check that retrying a package delivery doesn't delete an event file Co-authored-by: Michael Haney <mikehaney24@users.noreply.github.com> Co-authored-by: Maksym Malyhin <mmaksym@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the upload coordinator removes events from disk when the upload was unsuccessful and should be retried in the future.