Skip to content

Remove cleanup of experiments that are no longer running #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Remove cleanup of experiments that are no longer running #5078

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a49b97
Remove cleanup of experiments that are no longer running (product dec…
christibbs Mar 11, 2020
b1f1c1d
Revert podspec bump
christibbs Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions FirebaseInAppMessaging/Sources/Flows/FIRIAMMsgFetcherUsingRestful.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@
#import "FIRIAMMsgFetcherUsingRestful.h"
#import "FIRIAMSDKSettings.h"

#import <FirebaseABTesting/FIRExperimentController.h>

static NSInteger const SuccessHTTPStatusCode = 200;

@interface FIRIAMMsgFetcherUsingRestful ()
Expand Down Expand Up @@ -187,18 +185,6 @@ - (void)fetchMessagesWithImpressionList:(NSArray<FIRIAMImpressionRecord *> *)imp
@"API request for fetching messages and parsing the response was "
"successful.");

// Validate running experiments with ABT.
NSMutableArray *runningExperiments = [[NSMutableArray alloc] init];
for (FIRIAMMessageDefinition *messageDefinition in messages) {
if (messageDefinition.experimentPayload) {
[runningExperiments addObject:messageDefinition.experimentPayload];
}
}

[[FIRExperimentController sharedInstance]
validateRunningExperimentsForServiceOrigin:@"fiam"
runningExperimentPayloads:[runningExperiments copy]];

[self.fetchStorage
saveResponseDictionary:responseDict
withCompletion:^(BOOL success) {
Expand Down