Skip to content

Consolidate the Google Analytics origins for Crashlytics #5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Consolidate the Google Analytics origins for Crashlytics #5030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions Crashlytics/Crashlytics/Helpers/FIRCLSFCRAnalytics.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@
// Origin for events and user properties generated by Crashlytics.
static NSString *const kFIREventOriginCrash = @"clx";

// Origin for events and user properties generated by Crash Reporting.
// We're using this for now because it's whitelisted, and "clx" is not.
// TODO(b/144163610) add a separate parameter for Crashlytics
static NSString *const kFIREventListenerOriginCrash = @"crash";

// App exception event name.
static NSString *const kFIREventAppException = @"_ae";

Expand All @@ -36,13 +31,6 @@
// Fatal key for the event payload.
static NSString *const kFIRParameterFatal = @"fatal";

// Realtime flag
// TODO(b/144114243) We had to remove this because it's blacklisted.
// Previously, the value was set as:
// static NSString *const kFIRParameterRealtime = @"_r";
// and used in buildLogParamsFromCrash as:
// kFIRParameterRealtime : @(INT64_C(1)),

FOUNDATION_STATIC_INLINE NSNumber *timeIntervalInMillis(NSTimeInterval timeInterval) {
return @(llrint(timeInterval * 1000.0));
}
Expand All @@ -66,7 +54,7 @@ + (void)registerEventListener:(id<FIRAnalyticsInteropListener>)eventListener
return;
}

[analytics registerAnalyticsListener:eventListener withOrigin:kFIREventListenerOriginCrash];
[analytics registerAnalyticsListener:eventListener withOrigin:kFIREventOriginCrash];

FIRCLSDeveloperLog(@"Crashlytics:Crash:Reports:Event",
"Registered Firebase Analytics event listener");
Expand Down