Skip to content

Ignore deprecation warnings for FIRExperimentController.updateExperiments(serviceOrigin:events:policy:lastStartTime:payloads:) #4934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Ignore deprecation warnings for FIRExperimentController.updateExperiments(serviceOrigin:events:policy:lastStartTime:payloads:) #4934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion FirebaseRemoteConfig/Sources/RCNConfigExperiment.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,13 +183,15 @@ - (void)updateExperiments {

// Update the last experiment start time with the latest payload.
[self updateExperimentStartTime];

#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
[self.experimentController
updateExperimentsWithServiceOrigin:kServiceOrigin
events:lifecycleEvent
policy:ABTExperimentPayload_ExperimentOverflowPolicy_DiscardOldest
lastStartTime:lastStartTime
payloads:_experimentPayloads];
#pragma clang diagnostic pop
}

- (void)updateExperimentStartTime {
Expand Down
3 changes: 3 additions & 0 deletions FirebaseRemoteConfig/Tests/Unit/RCNConfigExperimentTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,8 @@ - (void)testUpdateExperiments {

NSTimeInterval lastStartTime =
[experiment.experimentMetadata[@"last_experiment_start_time"] doubleValue];
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
OCMStub(
[mockExperimentController
updateExperimentsWithServiceOrigin:[OCMArg any]
Expand All @@ -225,6 +227,7 @@ - (void)testUpdateExperiments {
lastStartTime:lastStartTime
payloads:[OCMArg any]])
.andDo(nil);
#pragma clang diagnostic pop

ABTExperimentPayload *payload = [[ABTExperimentPayload alloc] init];
payload.experimentStartTimeMillis = 12345678000;
Expand Down