Skip to content

Remove unused files in IID #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2020
Merged

Remove unused files in IID #4881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
940ec86
remove unused files in IID
charlotteliang Feb 11, 2020
7b36b90
fix format
charlotteliang Feb 11, 2020
6849346
also remove unused debug code
charlotteliang Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Firebase/InstanceID/FIRIMessageCode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,5 @@ typedef NS_ENUM(NSInteger, FIRInstanceIDMessageCode) {
kFIRInstanceIDKeychainCreateKeyPairError = 23003,
kFIRInstanceIDKeychainUpdateItemError = 23004,

// FIRInstanceIDStringEncoding.m
kFIRInstanceIDStringEncodingBufferUnderflow = 24000,
kFIRInstanceIDStringEncodingBufferOverflow = 24001,

// DO NOT USE 24000, 24001
};
66 changes: 0 additions & 66 deletions Firebase/InstanceID/FIRInstanceIDStringEncoding.h
View file
Open in desktop

This file was deleted.

208 changes: 0 additions & 208 deletions Firebase/InstanceID/FIRInstanceIDStringEncoding.m
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions Firebase/Messaging/FIRMessagingTopicOperation.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
#import "Firebase/Messaging/FIRMessagingUtilities.h"
#import "Firebase/Messaging/NSError+FIRMessaging.h"

#define DEBUG_LOG_SUBSCRIPTION_OPERATION_DURATIONS 0

static NSString *const kFIRMessagingSubscribeServerHost =
@"https://iid.googleapis.com/iid/register";

Expand Down Expand Up @@ -194,10 +192,6 @@ - (void)performSubscriptionChange {
request.HTTPBody = [content dataUsingEncoding:NSUTF8StringEncoding];
[request setHTTPMethod:@"POST"];

#if DEBUG_LOG_SUBSCRIPTION_OPERATION_DURATIONS
NSDate *start = [NSDate date];
#endif

FIRMessaging_WEAKIFY(self) void (^requestHandler)(NSData *, NSURLResponse *, NSError *) =
^(NSData *data, NSURLResponse *URLResponse, NSError *error) {
FIRMessaging_STRONGIFY(self) if (error) {
Expand Down Expand Up @@ -228,10 +222,6 @@ - (void)performSubscriptionChange {
[self finishWithError:[NSError errorWithFCMErrorCode:kFIRMessagingErrorCodeUnknown]];
return;
}
#if DEBUG_LOG_SUBSCRIPTION_OPERATION_DURATIONS
NSTimeInterval duration = -[start timeIntervalSinceNow];
FIRMessagingLoggerDebug(@"%@ change took %.2fs", self.topic, duration);
#endif
[self finishWithError:nil];
};

Expand Down