Use a prefix scan when fetching documents matching a query. #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor optimization (which is already present in the ts code).
| XCTAssertEqual([results count], [expected count]); | ||
| for (FSTDocument *doc in expected) { | ||
| XCTAssertEqualObjects([results objectForKey:doc.key], doc); | ||
| } |
There was a problem hiding this comment.
The TODO below is now no longer relevant, is it?
| FSTDocumentDictionary *results = [self.remoteDocumentCache documentsMatchingQuery:query]; | ||
| NSArray *expected = | ||
| @[ FSTTestDoc(@"b/1", kVersion, _kDocData, NO), FSTTestDoc(@"b/2", kVersion, _kDocData, NO) ]; | ||
| XCTAssertEqual([results count], [expected count]); |
There was a problem hiding this comment.
Can you also port the comment from JS (which is a little more descriptive than we we have here).
// TODO(mikelehen): This just verifies that we do a prefix scan against the
// query path. We'll need more tests once we add index support.
- remove now-redundant TODO - add more descriptive text to the test (ported from ts code).
schmidt-sebastian
approved these changes
Nov 22, 2017
rsgowman
deleted the
rgowman-filter_documents_matching_query_by_prefix
branch
minafarid
pushed a commit
to minafarid/firebase-ios-sdk
that referenced
this pull request
Jun 6, 2018
…#488) Minor optimization (which is already present in the ts code).
paulb777
added a commit
that referenced
this pull request
Aug 21, 2019
* Initial source drop - sync'd at 263414281 * Public headers * Initial podspec and 1st pass at imports * initial build fixes * Successful library and tests build * Two test failures left * All unit tests pass * Initial look at unused tests * Fix macOS build (no need for import UIKit) * style * Add copyrights * Use, obfuscate, and verify 2nd App plist * fix some warnings * Fix analyze issues * Changelog updates * Minor comment cleanup.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor optimization (which is already present in the ts code).
http://b/36351543