Skip to content

Map the read values from user key value, error and log .clsrecords into the Report nanopb model #4840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 6, 2020
Merged

Map the read values from user key value, error and log .clsrecords into the Report nanopb model #4840

merged 5 commits into from
Feb 6, 2020

Conversation

@jasonhu-g
Copy link
Contributor

@jasonhu-g jasonhu-g commented Feb 6, 2020 •
edited
Loading

This is a follow up to: #4793

  1. Map the read values from user key value, error and log .clsrecords into the Report nanopb models
  2. Add TODOs to track potential logic that we have to move from protobuilder into the SDK

The next related PR will be to add unit tests for protobuilder logic that has been moved into the SDK.

@jasonhu-g jasonhu-g requested a review from samedson February 6, 2020 16:37
samedson
samedson reviewed Feb 6, 2020
View reviewed changes
samedson
samedson reviewed Feb 6, 2020
View reviewed changes
@jasonhu-g jasonhu-g changed the title Map the read values from user key value, error and log .clsrecords into the Report nanopb models Map the read values from user key value, error and log .clsrecords into the Report nanopb model Feb 6, 2020
@jasonhu-g jasonhu-g merged commit 06a1491 into crashlytics-firelog Feb 6, 2020
@jasonhu-g jasonhu-g deleted the jasonhu-clsRecordToProtoMapping branch February 6, 2020 21:15
@firebase firebase locked and limited conversation to collaborators Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@samedson samedson samedson approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasonhu-g @samedson @googlebot