Skip to content

if_changed.sh: add InstanceID and Installations to all dependent SDKs #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 15, 2020
Merged

if_changed.sh: add InstanceID and Installations to all dependent SDKs #4687

merged 3 commits into from
Jan 15, 2020

Conversation

@maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Jan 15, 2020 •
edited
Loading

#no-changelog

ryanwilson
ryanwilson reviewed Jan 15, 2020
View reviewed changes
scripts/if_changed.sh Outdated
Crashlytics-*)
check_changes '^(FirebaseCore|Firebase/InstanceID|Firebase/Installations|GoogleUtilities|Crashlytics|FirebaseCrashlytics.podspec)'
check_changes '^(FirebaseCore|GoogleUtilities|Crashlytics|FirebaseCrashlytics.podspec|Firebase/InstanceID|FirebaseInstanceID.podspec|'\
'FirebaseInstallations|FirebaseInstallations.podspec)'
Copy link
Member

@ryanwilson ryanwilson Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think FirebaseInstallations.podspec will be caught by the FirebaseInstallations regex itself, so we should be okay with just that. I think that's why FirebaseCore is alone without the .podspec too. Same as below.

Copy link
Contributor Author

@maksymmalyhin maksymmalyhin Jan 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, ideally, we should add podspecs for all dependencies as well in order to catch platforms, versions, etc. mismatches when they are changed in a dependency podspec. I feel like handling it in a more generic way separately in #4688 though.

Copy link
Member

@ryanwilson ryanwilson Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with handling it a more general way, thanks for filing that. I was just noting that I think the regex itself catches FirebaseInstallations.podspec when you only include FirebaseInstallations and don't need to explicitly call out the podspec.

Copy link
Contributor Author

@maksymmalyhin maksymmalyhin Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you are right! I'll update it.

@maksymmalyhin maksymmalyhin mentioned this pull request Jan 15, 2020
Merged
ryanwilson
ryanwilson approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on travis green

@maksymmalyhin maksymmalyhin merged commit b68ad62 into master Jan 15, 2020
@maksymmalyhin maksymmalyhin deleted the mm/if_changed branch January 15, 2020 16:34
@firebase firebase locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maksymmalyhin @ryanwilson @googlebot