Skip to content

Firebase Installations: validation of FIROptions parameters #4683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Jan 16, 2020
Merged

Firebase Installations: validation of FIROptions parameters #4683

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d2ea3bc
FIS: Throw exception on incomplete Firebase config.
maksymmalyhin Jan 15, 2020
2f6898b
API docs updated.
maksymmalyhin Jan 15, 2020
501af60
FirebaseInstallations bump minor version: 1.1.0
maksymmalyhin Jan 15, 2020
381f9a9
Fix tests
maksymmalyhin Jan 15, 2020
1254d1a
Text fixed
maksymmalyhin Jan 15, 2020
45208a6
Make exception message more informative
maksymmalyhin Jan 15, 2020
060740c
Merge remote-tracking branch 'origin/master' into mm/fis-config
maksymmalyhin Jan 15, 2020
832adfa
Fix Remote Config tests.
maksymmalyhin Jan 15, 2020
dac08c6
Merge branch 'master' into mm/fis-config
maksymmalyhin Jan 15, 2020
9af869a
Tests updated to use GCMSenderID if projectID is not available.
maksymmalyhin Jan 15, 2020
83afada
Use `GCMSenderID` when `projectID` is not available.
maksymmalyhin Jan 15, 2020
5a74f2e
./scripts/style.sh
maksymmalyhin Jan 15, 2020
724ce8f
Comments
maksymmalyhin Jan 15, 2020
bff6efd
GCMSenderID and projectID validation updated.
maksymmalyhin Jan 16, 2020
45d1a6a
Comment
maksymmalyhin Jan 16, 2020
43934b5
FirebaseInstallations: version bump to 1.0.1.
maksymmalyhin Jan 16, 2020
3f58525
FIS changelog
maksymmalyhin Jan 16, 2020
6fbb14d
FirebaseInstallations: version bump to 1.1.0
maksymmalyhin Jan 16, 2020
1761ed6
FIS and Core changelogs.
maksymmalyhin Jan 16, 2020
22c527d
Changelogs remove GCMSenderID
maksymmalyhin Jan 16, 2020
0fd43bf
Typo
maksymmalyhin Jan 16, 2020
e1d0cf2
Typo
maksymmalyhin Jan 16, 2020
87922d5
fix link
maksymmalyhin Jan 16, 2020
d7ef952
Revert Core changelog
maksymmalyhin Jan 16, 2020
c68b86c
FIS changelog fix.
maksymmalyhin Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions FirebaseCore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# v6.6.0 -- M62
- [changed] Reorganized directory structure.
- [changed] Firebase Installations(../../FirebaseInstallations/CHANGELOG.md) throws an exception when there are missing required `FirebaseOptions` parameters (`APIKey`, `googleAppID`, and `projectID` or `GCMSenderID`). Please make sure your `GoogleServices-Info.plist` (or `FirebaseOptions` if you configure Firebase in code) are up to date. The file and settings can be downoaded from the [Firebase Console](https://console.firebase.google.com/). (#4683)
Copy link
Contributor

@andirayo andirayo Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

downloaded

is missing an "L"

- [changed] The following SDKs introduce a new transitive dependency on the [Firebase Installations API](https://console.cloud.google.com/apis/library/firebaseinstallations.googleapis.com):
- Analytics
- Cloud Messaging
Expand Down
4 changes: 2 additions & 2 deletions FirebaseInstallations/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# v1.0.1 -- M62
# v1.1.0 -- M62.1

- [changed] Throw an exception when there are missing required `FIROptions` parameters. (#4683)
- [changed] Throw an exception when there are missing required `FirebaseOptions` parameters (`APIKey`, `googleAppID`, and `projectID` or `GCMSenderID`). Please make sure your `GoogleServices-Info.plist` (or `FirebaseOptions` if you configure Firebase in code) are up to date. The file and settings can be downoaded from the [Firebase Console](https://console.firebase.google.com/). (#4683)
Copy link
Contributor

@andirayo andirayo Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Throws (with trailing "s")

I recommend to remove "GCMSenderID" and would not even mention it.
I think it has more potential to create confusion rather than help the developer understand what is happening.
If the developer changes something, we want him to add Project-ID.

Question: Is it called FirebaseOptions or FIROptions?


# v1.0.0 -- M62

Expand Down