Skip to content

Fix if_changed script for Crashlytics #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

Fix if_changed script for Crashlytics #4663

merged 1 commit into from
Jan 13, 2020

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Jan 11, 2020

Crashlytics is in currently located in the Crashlytics directory.

@google-oss-bot
Copy link

google-oss-bot commented Jan 11, 2020

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@paulb777 paulb777 mentioned this pull request Jan 12, 2020
Merged
ryanwilson
ryanwilson approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - should it be moved to FirebaseCrashlytics eventually or no?

@paulb777
Copy link
Member Author

paulb777 commented Jan 13, 2020

Yes - it should follow https://github.com/firebase/firebase-ios-sdk/blob/master/AddNewPod.md#directory-structure.

cc: @jasonhu-g @samedson

@jasonhu-g jasonhu-g self-requested a review January 13, 2020 15:14
@paulb777 paulb777 merged commit ba8ebce into master Jan 13, 2020
@paulb777 paulb777 deleted the pb-fix-crashlytics-ci branch January 13, 2020 15:15
@firebase firebase locked and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@samedson samedson samedson approved these changes

@ryanwilson ryanwilson ryanwilson approved these changes

+1 more reviewer

@jasonhu-g jasonhu-g jasonhu-g approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: crashlytics cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@paulb777 @google-oss-bot @samedson @ryanwilson @jasonhu-g @googlebot