Skip to content

FIRStorage.callbackQueue fixes #4281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2019
Merged

FIRStorage.callbackQueue fixes #4281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Firebase/Storage/FIRStorage.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ - (instancetype)copyWithZone:(NSZone *)zone {
FIRStorage *storage = [[[self class] allocWithZone:zone] initWithApp:_app
bucket:_storageBucket
auth:_auth];
storage.callbackQueue = _callbackQueue;
storage.callbackQueue = self.callbackQueue;
return storage;
}

Expand All @@ -195,7 +195,7 @@ - (BOOL)isEqualToFIRStorage:(FIRStorage *)storage {
}

- (NSUInteger)hash {
NSUInteger hash = [_app hash] ^ [_callbackQueue hash];
NSUInteger hash = [_app hash] ^ [self.callbackQueue hash];
return hash;
}

Expand Down Expand Up @@ -236,6 +236,10 @@ - (FIRStorageReference *)referenceWithPath:(NSString *)string {
return reference;
}

- (dispatch_queue_t)callbackQueue {
return _fetcherServiceForApp.callbackQueue;
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm. Sorry for already approving this, but doesn't this break the ability for the developer to specify an override for the callback queue?

Copy link
Contributor

@schmidt-sebastian schmidt-sebastian Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the solution to this mystery lies in line 244 :) Please ignore.

}

- (void)setCallbackQueue:(dispatch_queue_t)callbackQueue {
_fetcherServiceForApp.callbackQueue = callbackQueue;
}
Expand Down