Move FIRInstanceIDInstanceProvider into the private header file for components to look up an instance of FIRInstanceID #4037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omponents to look up an instance of FIRInstanceID
ryanwilson
reviewed
Oct 10, 2019
| * | ||
| * @return YES if valid checkin preferences exist in memory else NO. | ||
| */ | ||
| - (BOOL)hasValidCheckinInfo; |
There was a problem hiding this comment.
Yep, so Travis CI failed because XCode generated a warning where FIRInstanceID does not have an implementation for hasValidCheckinInfo. I think this is old code since there's no references to that method in FIRInstanceID anywhere. It looks like the code got refactored and that method no lives in FIRInstanceIDCheckinPreferences.
|
This change is no longer needed with a fix Core initialization (#4030) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move FIRInstanceIDInstanceProvider into the private header file for components to look up an instance of FIRInstanceID. This is needed when a components loads with componentsToRegister and depends on instanceID when initializing.