Firebase pod tests #4020
Merged
Firebase pod tests #4020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulb777 Just curious if |
paulb777
commented
Oct 8, 2019
There was a problem hiding this comment.
@maksymmalyhin That was my initial approach, but for a reason that I didn't debug, the test spec target doesn't get generated for the Firebase pod.
Also, the Xcode project needs a workaround as noted by the comment I added to work as a development pod.
| CODE_SIGN_STYLE = Automatic; | ||
| HEADER_SEARCH_PATHS = ( | ||
| "$(inherited)", | ||
| ../../../../Firebase/Firebase/Sources, |
There was a problem hiding this comment.
Workaround to make the Firebase pod work as a development pod
|
@paulb777 Thank you for explaining. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an integration test for the Firebase pod.
The key files are Firebase/Firebase/Tests/FirebasePodTest/FirebasePodTest/AppDelegate.swift and Firebase/Firebase/Tests/FirebasePodTest/Podfile
Also, some additional miscellaneous clean up to make travis happy for the Firebase pod.
The Firebase Pod work is in pb-firebase-pod and after approval, this PR will be merged and a combined PR to master sent.