Skip to content

Move two internal iid headers to private for RC open sourcing #3621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Move two internal iid headers to private for RC open sourcing #3621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e1df882
Move two internal iid headers to private for RC open sourcing
paulb777 Aug 18, 2019
ec14bd0
Fix xcode project build
paulb777 Aug 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Example/InstanceID/Tests/FIRInstanceIDCheckinServiceTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@

#import <OCMock/OCMock.h>
#import "Firebase/InstanceID/FIRInstanceIDCheckinPreferences+Internal.h"
#import "Firebase/InstanceID/FIRInstanceIDCheckinPreferences.h"
#import "Firebase/InstanceID/FIRInstanceIDCheckinService.h"
#import "Firebase/InstanceID/FIRInstanceIDUtilities.h"
#import "Firebase/InstanceID/NSError+FIRInstanceID.h"
#import "Firebase/InstanceID/Private/FIRInstanceIDCheckinPreferences.h"

static NSString *const kDeviceAuthId = @"1234";
static NSString *const kSecretToken = @"567890";
Expand Down
2 changes: 1 addition & 1 deletion Example/InstanceID/Tests/FIRInstanceIDCheckinStoreTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@
#import "Firebase/InstanceID/FIRInstanceIDAuthKeyChain.h"
#import "Firebase/InstanceID/FIRInstanceIDBackupExcludedPlist.h"
#import "Firebase/InstanceID/FIRInstanceIDCheckinPreferences+Internal.h"
#import "Firebase/InstanceID/FIRInstanceIDCheckinPreferences.h"
#import "Firebase/InstanceID/FIRInstanceIDCheckinService.h"
#import "Firebase/InstanceID/FIRInstanceIDCheckinStore.h"
#import "Firebase/InstanceID/FIRInstanceIDStore.h"
#import "Firebase/InstanceID/FIRInstanceIDUtilities.h"
#import "Firebase/InstanceID/FIRInstanceIDVersionUtilities.h"
#import "Firebase/InstanceID/Private/FIRInstanceIDCheckinPreferences.h"

static const NSTimeInterval kExpectationTimeout = 12;

Expand Down
2 changes: 1 addition & 1 deletion Example/InstanceID/Tests/FIRInstanceIDStoreTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
#import "FIRInstanceIDFakeKeychain.h"
#import "Firebase/InstanceID/FIRInstanceIDBackupExcludedPlist.h"
#import "Firebase/InstanceID/FIRInstanceIDCheckinPreferences+Internal.h"
#import "Firebase/InstanceID/FIRInstanceIDCheckinPreferences.h"
#import "Firebase/InstanceID/FIRInstanceIDCheckinService.h"
#import "Firebase/InstanceID/FIRInstanceIDCheckinStore.h"
#import "Firebase/InstanceID/FIRInstanceIDStore.h"
#import "Firebase/InstanceID/FIRInstanceIDTokenInfo.h"
#import "Firebase/InstanceID/FIRInstanceIDTokenStore.h"
#import "Firebase/InstanceID/FIRInstanceIDUtilities.h"
#import "Firebase/InstanceID/Private/FIRInstanceIDCheckinPreferences.h"

static NSString *const kSubDirectoryName = @"FirebaseInstanceIDStoreTest";

Expand Down
2 changes: 1 addition & 1 deletion Firebase/InstanceID/FIRInstanceIDCheckinPreferences+Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#import "FIRInstanceIDCheckinPreferences.h"
#import "Private/FIRInstanceIDCheckinPreferences.h"

@interface FIRInstanceIDCheckinPreferences (Internal)

Expand Down
2 changes: 1 addition & 1 deletion Firebase/InstanceID/FIRInstanceIDCheckinPreferences_Private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
* limitations under the License.
*/

#import "FIRInstanceIDCheckinPreferences.h"
#import "Private/FIRInstanceIDCheckinPreferences.h"

/** Checkin refresh interval. **/
FOUNDATION_EXPORT const NSTimeInterval kFIRInstanceIDDefaultCheckinInterval;
Expand Down
3 changes: 1 addition & 2 deletions Firebase/InstanceID/FIRInstanceID+Private.h → ...nstanceID/Private/FIRInstanceID+Private.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@
#import "FIRInstanceIDCheckinService.h"

/**
* Internal API used by Firebase SDK teams by calling in reflection or internal teams.
* Private API used by Firebase SDK teams by calling in reflection or internal teams.
*/
// TODO(chliangGoogle) Rename this to Internal.
@interface FIRInstanceID (Private)

/**
Expand Down
0 ...tanceID/FIRInstanceIDCheckinPreferences.h → ...Private/FIRInstanceIDCheckinPreferences.h
View file
Open in desktop
File renamed without changes.