Skip to content

Declare dependency on AppKit to fix Firestore build #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Declare dependency on AppKit to fix Firestore build #3459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cd462e
Declare dependency on AppKit to fix Firestore build
wilhuff Jul 29, 2019
e7ae406
Add equivalent UIKit dependencies for iOS and tvOS
wilhuff Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions FirebaseCore.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ Firebase Core includes FIRApp and FIROptions which provide central configuration
s.public_header_files = 'Firebase/Core/Public/*.h', 'Firebase/Core/Private/*.h'
s.private_header_files = 'Firebase/Core/Private/*.h'
s.framework = 'Foundation'
s.ios.framework = 'UIKit'
s.osx.framework = 'AppKit'
Copy link
Member

@paulb777 paulb777 Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It also needs

s.ios.framework = 'UIKit'
s.tvos.framework = 'UIKit'

Copy link
Contributor Author

@wilhuff wilhuff Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (in alphabetical order, matching the order of deployment_target above).

s.tvos.framework = 'UIKit'
s.dependency 'GoogleUtilities/Environment', '~> 6.2'
s.dependency 'GoogleUtilities/Logger', '~> 6.2'
s.dependency 'FirebaseCoreDiagnosticsInterop', '~> 0.1'
Expand Down