Skip to content

Fix FIRDocumentChange returning incorrect values for not found #3361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2019
Merged

Fix FIRDocumentChange returning incorrect values for not found #3361

merged 3 commits into from
Jul 16, 2019

Conversation

@wilhuff
Copy link
Contributor

@wilhuff wilhuff commented Jul 15, 2019

Fixes #3298.

@wilhuff wilhuff requested a review from var-const July 15, 2019 21:51
@var-const var-const assigned wilhuff and unassigned var-const Jul 15, 2019
@wilhuff wilhuff merged commit ec35576 into master Jul 16, 2019
@wilhuff wilhuff deleted the wilhuff/not-found branch July 16, 2019 01:00
@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@var-const var-const var-const approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wilhuff wilhuff

Labels

api: firestore cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FIRDocumentChange newIndex not being set as NSNotFound

3 participants

@wilhuff @var-const @googlebot