Skip to content

Stop calling deprecated sendLogsWithServiceName #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Stop calling deprecated sendLogsWithServiceName #3333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Firebase/DynamicLinks/FIRDynamicLinks.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@ - (void)configureDynamicLinks:(FIRApp *)app {
reason:errorDescription];
}
if (error) {
[app sendLogsWithServiceName:kFIRServiceDynamicLinks version:kFIRDLVersion error:error];
NSString *message = nil;
if (options.usingOptionsFromDefaultPlist) {
// Configured using plist file
Expand Down
6 changes: 0 additions & 6 deletions Firebase/InstanceID/FIRInstanceID.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,13 +697,7 @@ + (NSError *)configureErrorWithReason:(nonnull NSString *)reason {
userInfo:userInfo];
}

// If the firebaseApp is available we should send logs for the error through it before
// raising an exception.
+ (void)exitWithReason:(nonnull NSString *)reason forFirebaseApp:(FIRApp *)firebaseApp {
[firebaseApp sendLogsWithServiceName:kFIRIIDServiceInstanceID
version:FIRInstanceIDCurrentLibraryVersion()
error:[self configureErrorWithReason:reason]];

[NSException raise:kFIRIIDErrorDomain
format:@"Could not configure Firebase InstanceID. %@", reason];
}
Expand Down