Skip to content

In card message: set the text color on the body text view #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2019
Merged

In card message: set the text color on the body text view #3286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
799f2db
In card message: set the text color on the body text view
christibbs Jul 1, 2019
6b49aae
Fix bug where card messages in test app were showing up with two of t…
christibbs Jul 1, 2019
e245e47
Revert change to text color
christibbs Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Firebase/InAppMessagingDisplay/Card/FIDCardViewController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ - (void)viewDidLoad {
self.titleLabel.textColor = self.cardDisplayMessage.textColor;

self.bodyTextView.text = self.cardDisplayMessage.body;
self.bodyTextView.textColor = self.cardDisplayMessage.textColor;

[self.primaryActionButton setTitle:self.cardDisplayMessage.primaryActionButton.buttonText
forState:UIControlStateNormal];
Expand Down
2 changes: 1 addition & 1 deletion InAppMessagingDisplay/Example/FiamDisplaySwiftExample/CardMessageViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class CardMessageViewController: CommonMessageTestVC {
}

override var secondaryActionButton: InAppMessagingActionButton? {
return writablePrimaryActionButton
return writableSecondaryActionButton
}

override var secondaryActionURL: URL? {
Expand Down