Skip to content

Revert "Raise exception when log into Facebook using OAuth. (#3138)" #3208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2019
Merged

Revert "Raise exception when log into Facebook using OAuth. (#3138)" #3208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions Firebase/Auth/Source/AuthProvider/OAuth/FIROAuthProvider.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,9 @@
#import "FIRAuthBackend.h"
#import "FIRAuth_Internal.h"
#import "FIRAuthErrorUtils.h"
#import "FIRAuthExceptionUtils.h"
#import "FIRAuthGlobalWorkQueue.h"
#import "FIRAuthRequestConfiguration.h"
#import "FIRAuthWebUtils.h"
#import "FIRFacebookAuthProvider.h"
#import "FIROAuthCredential_Internal.h"
#import "FIROAuthCredential.h"

Expand Down Expand Up @@ -167,12 +165,6 @@ - (void)getCredentialWithUIDelegate:(nullable id<FIRAuthUIDelegate>)UIDelegate
@return An Instance of @c FIROAuthProvider.
*/
- (nullable instancetype)initWithProviderID:(NSString *)providerID auth:(FIRAuth *)auth {
if ([providerID isEqual:FIRFacebookAuthProviderID]) {
[FIRAuthExceptionUtils raiseInvalidParameterExceptionWithReason:
@"Sign in with Facebook is not supported via this method; the Facebook TOS "
"dictate that you must use the Facebook iOS SDK for Facebook login."];
return nil;
}
self = [super init];
if (self) {
_auth = auth;
Expand Down