Defend against nil bundle identifiers #3188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes #3184, where under some circumstances some bundles have no CFBundleIdentifier in their Info.plist.
wilhuff
force-pushed
the
wilhuff/bundle-identifier
branch
from
cf88c0e to
2219cc0
Compare
schmidt-sebastian
approved these changes
Jun 14, 2019
Firestore/core/src/firebase/firestore/remote/grpc_root_certificate_finder_apple.mm
Outdated
Show resolved
Hide resolved
| if (!bundle) return "(nil bundle)"; | ||
|
|
||
| NSString* identifier = [bundle bundleIdentifier]; | ||
| if (!identifier) { |
There was a problem hiding this comment.
Since this is still Objective-C, this function could be:
NSString* identifier = [bundle bundleIdentifier];
identifier = [bundle bundlePath];
return identifier ? util::MakeString(identifier) : "(missing bundle identifier)";
Your version is much more explicit, though, and you can leave it as is.
There was a problem hiding this comment.
The second line of your suggestion doesn't work since we only want to do that if the -bundleIdentifier returned nil.
In general I'm not in favor of relying on nil dispatch. It's too easy to accidentally do when it's not intended and when reading code later it's hard to understand if it's intended or not. It also hides the conditional behavior in a way that's easy to overlook.
I did make the final line the ternary though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3184, where under some circumstances some bundles have no
CFBundleIdentifier in their Info.plist.