Implement Firebase CoreDiagnostics

.travis.yml

@@ -140,6 +140,7 @@ jobs:
         - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseAnalyticsInterop.podspec
         - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseAuth.podspec
         - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseAuthInterop.podspec
+        - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseCoreDiagnosticsInterop.podspec
         - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseInAppMessaging.podspec
         - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseInAppMessagingDisplay.podspec
 
@@ -164,6 +165,7 @@ jobs:
         - travis_retry ./scripts/pod_lib_lint.rb FirebaseAnalyticsInterop.podspec --use-libraries
         - travis_retry ./scripts/pod_lib_lint.rb FirebaseAuth.podspec --use-libraries
         - travis_retry ./scripts/pod_lib_lint.rb FirebaseAuthInterop.podspec --use-libraries
+        - travis_retry ./scripts/pod_lib_lint.rb FirebaseCoreDiagnosticsInterop.podspec --use-libraries
         - travis_retry ./scripts/pod_lib_lint.rb FirebaseInAppMessaging.podspec --use-libraries
         - travis_retry ./scripts/pod_lib_lint.rb FirebaseInAppMessagingDisplay.podspec --use-libraries
         - travis_retry ./scripts/if_changed.sh ./scripts/pod_lib_lint.rb FirebaseInstanceID.podspec --use-libraries --platforms=ios

CMakeLists.txt

@@ -224,6 +224,27 @@ podspec_framework(
 
 podspec_framework(${FIREBASE_SOURCE_DIR}/FirebaseCore.podspec)
 
+podspec_framework(
+  ${FIREBASE_SOURCE_DIR}/FirebaseCoreDiagnosticsInterop.podspec
+)
+
+if(APPLE)
+  # FirebaseCoreDiagnosticsInterop has no source files but CMake can't build
+  # frameworks that don't have sources. Generate an inconsequential source
+  # file so that the library can be linked.
+  file(
+    WRITE ${CMAKE_CURRENT_BINARY_DIR}/FirebaseCoreDiagnosticsInteropDummy.c
+    "// generated file for header-only CMake support.
+    __attribute__((unused))
+    static void FirebaseCoreDiagnosticsInteropFakeSymbol() {}
+    "
+  )
+  target_sources(
+    FirebaseCoreDiagnosticsInterop
+    PRIVATE ${CMAKE_CURRENT_BINARY_DIR}/FirebaseCoreDiagnosticsInteropDummy.c
+  )
+endif()
+
 podspec_framework(${FIREBASE_SOURCE_DIR}/FirebaseAuthInterop.podspec)
 
 if(APPLE)

Example/Core/Tests/FIRAppTest.m

@@ -15,6 +15,8 @@
 #import "FIRTestCase.h"
 #import "FIRTestComponents.h"
 
+#import <FirebaseCoreDiagnosticsInterop/FIRCoreDiagnosticsData.h>
+
 #import <FirebaseCore/FIRAnalyticsConfiguration.h>
 #import <FirebaseCore/FIRAppInternal.h>
 #import <FirebaseCore/FIROptionsInternal.h>
@@ -620,7 +622,7 @@ - (void)testGlobalDataCollectionNoDiagnosticsSent {
   // Add an observer for the diagnostics notification. Currently no object is sent, but in the
   // future that could change so leave it as OCMOCK_ANY.
   [self.notificationCenter addMockObserver:self.observerMock
-                                      name:kFIRAppDiagnosticsNotification
+                                      name:kFIRDiagnosticsNotification
                                     object:OCMOCK_ANY];
 
   // Stub out reading from user defaults since stubbing out the BOOL has issues. If the data
@@ -632,8 +634,7 @@ - (void)testGlobalDataCollectionNoDiagnosticsSent {
   // Ensure configure doesn't fire a notification.
   [FIRApp configure];
 
-  NSError *error = [NSError errorWithDomain:@"com.firebase" code:42 userInfo:nil];
-  [app sendLogsWithServiceName:@"Service" version:@"Version" error:error];
+  [app sendLogsWithServiceName:@"Service" version:@"Version"];
 
   // The observer mock is strict and will raise an exception when an unexpected notification is
   // received.

Example/Core/Tests/FIRDiagnosticsDataTest.m

@@ -0,0 +1,48 @@
+/*
+ * Copyright 2019 Google
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#import <XCTest/XCTest.h>
+
+#import <FirebaseCore/FIRDiagnosticsData.h>
+
+@interface FIRDiagnosticsDataTest : XCTestCase
+
+@end
+
+@implementation FIRDiagnosticsDataTest
+
+/** Tests initialization. */
+- (void)testInit {
+  FIRDiagnosticsData *data = [[FIRDiagnosticsData alloc] init];
+  XCTAssertNotNil(data);
+}
+
+/** Tests that -diagnosticObjects returns a valid default dictionary. */
+- (void)testFIRCoreDiagnosticsData {
+  FIRDiagnosticsData *data = [[FIRDiagnosticsData alloc] init];
+  XCTAssertNotNil(data.diagnosticObjects);
+  XCTAssertNotNil(data.diagnosticObjects[kFIRCDIsDataCollectionDefaultEnabledKey]);
+  XCTAssertNotNil(data.diagnosticObjects[kFIRCDllAppsCountKey]);
+  XCTAssertNotNil(data.diagnosticObjects[kFIRCDFirebaseUserAgentKey]);
+}
+
+/** Tests that setting diagnosticObjects throws. */
+- (void)testSettingDiagnosticObjectsThrows {
+  FIRDiagnosticsData *data = [[FIRDiagnosticsData alloc] init];
+  XCTAssertThrows(data.diagnosticObjects = @{});
+}
+
+@end

Example/Firebase.xcodeproj/project.pbxproj

@@ -5751,6 +5751,7 @@
 					"\"${PODS_ROOT}/Headers/Public\"",
 					"\"${PODS_ROOT}/Headers/Public/FirebaseAnalyticsInterop\"",
 					"\"${PODS_ROOT}/Headers/Public/FirebaseAuthInterop\"",
+					"\"${PODS_ROOT}/Headers/Public/FirebaseCoreDiagnosticsInterop\"",
 				);
 				INFOPLIST_FILE = "$(SRCROOT)/Messaging/App/tvOS/Info.plist";
 				LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
@@ -5828,6 +5829,7 @@
 					"\"${PODS_ROOT}/Headers/Public\"",
 					"\"${PODS_ROOT}/Headers/Public/FirebaseAnalyticsInterop\"",
 					"\"${PODS_ROOT}/Headers/Public/FirebaseAuthInterop\"",
+					"\"${PODS_ROOT}/Headers/Public/FirebaseCoreDiagnosticsInterop\"",
 					"\"${PODS_ROOT}/Headers/Private\"",
 					"\"${PODS_ROOT}/../../Firebase/Messaging\"",
 				);
@@ -5875,6 +5877,7 @@
 					"\"${PODS_ROOT}/Headers/Public\"",
 					"\"${PODS_ROOT}/Headers/Public/FirebaseAnalyticsInterop\"",
 					"\"${PODS_ROOT}/Headers/Public/FirebaseAuthInterop\"",
+					"\"${PODS_ROOT}/Headers/Public/FirebaseCoreDiagnosticsInterop\"",
 					"\"${PODS_ROOT}/../../Firebase/Messaging\"",
 				);
 				INFOPLIST_FILE = Messaging/Tests/Info.plist;

Example/Podfile

@@ -10,6 +10,7 @@ use_frameworks!
 pod 'FirebaseAnalyticsInterop', :path => '../'
 pod 'FirebaseAuthInterop', :path => '../'
 pod 'FirebaseCore', :path => '../'
+pod 'FirebaseCoreDiagnosticsInterop', :path => '../'
 pod 'GoogleUtilities', :path => '../'
 
 target 'Core_Example_iOS' do
@@ -127,6 +128,7 @@ target 'Auth_Sample' do
   platform :ios, '8.0'
   pod 'FirebaseAuth', :path => '../'
   pod 'FirebaseCore', :path => '../'
+  pod 'FirebaseCoreDiagnosticsInterop', :path => '../'
   pod 'FBSDKLoginKit'
   pod 'GoogleSignIn'
   pod 'FirebaseInstanceID', :path => '../'
@@ -146,6 +148,7 @@ target 'Core_Example_macOS' do
   platform :osx, '10.11'
 
   pod 'FirebaseCore', :path => '../'
+  pod 'FirebaseCoreDiagnosticsInterop', :path => '../'
 
   target 'Core_Tests_macOS' do
     inherit! :search_paths

Example/tvOSSample/Podfile

@@ -7,6 +7,7 @@ target 'tvOSSample' do
 
   # Pods for tvOSSample
   pod 'FirebaseCore', :path => '../../'
+  pod 'FirebaseCoreDiagnosticsInterop', :path => '../../'
   pod 'FirebaseAuth', :path => '../../'
   pod 'FirebaseDatabase', :path => '../../'
   pod 'FirebaseStorage', :path => '../../'

Firebase/Core/FIRApp.m

@@ -15,11 +15,15 @@
 #include <sys/utsname.h>
 
 #import "FIRApp.h"
+
+#import <FirebaseCoreDiagnosticsInterop/FIRCoreDiagnosticsData.h>
+
 #import "Private/FIRAnalyticsConfiguration.h"
 #import "Private/FIRAppInternal.h"
 #import "Private/FIRBundleUtil.h"
 #import "Private/FIRComponentContainerInternal.h"
 #import "Private/FIRConfigurationInternal.h"
+#import "Private/FIRDiagnosticsData.h"
 #import "Private/FIRLibrary.h"
 #import "Private/FIRLogger.h"
 #import "Private/FIROptionsInternal.h"
@@ -54,10 +58,7 @@
 NSString *const kFIRGlobalAppDataCollectionEnabledPlistKey =
     @"FirebaseDataCollectionDefaultEnabled";
 
-NSString *const kFIRAppDiagnosticsNotification = @"FIRAppDiagnosticsNotification";
-
 NSString *const kFIRAppDiagnosticsConfigurationTypeKey = @"ConfigType";
-NSString *const kFIRAppDiagnosticsErrorKey = @"Error";
 NSString *const kFIRAppDiagnosticsFIRAppKey = @"FIRApp";
 NSString *const kFIRAppDiagnosticsSDKNameKey = @"SDKName";
 NSString *const kFIRAppDiagnosticsSDKVersionKey = @"SDKVersion";
@@ -107,15 +108,22 @@ + (void)configure {
     // since the app isn't configured at all, so only rely on the Info.plist value.
     NSNumber *collectionEnabledPlistValue = [[self class] readDataCollectionSwitchFromPlist];
     if (collectionEnabledPlistValue == nil || [collectionEnabledPlistValue boolValue]) {
-      [[NSNotificationCenter defaultCenter]
-          postNotificationName:kFIRAppDiagnosticsNotification
-                        object:nil
-                      userInfo:@{
-                        kFIRAppDiagnosticsConfigurationTypeKey : @(FIRConfigTypeCore),
-                        kFIRAppDiagnosticsErrorKey : [FIRApp errorForMissingOptions]
-                      }];
+      if (NSClassFromString(@"FIRDiagnostics")) {
+        FIRDiagnosticsData *diagnosticsData = [[FIRDiagnosticsData alloc] init];
+        [diagnosticsData insertValueIfNotNil:collectionEnabledPlistValue
+                                      forKey:kFIRCDIsDataCollectionDefaultEnabledKey];
+        [diagnosticsData insertValueIfNotNil:[FIRApp firebaseUserAgent]
+                                      forKey:kFIRCDFirebaseUserAgentKey];
+        [diagnosticsData insertValueIfNotNil:@(FIRConfigTypeCore)
+                                      forKey:kFIRCDConfigurationTypeKey];
+        [[NSNotificationCenter defaultCenter]
+            postNotificationName:kFIRDiagnosticsNotification
+                          object:nil
+                        userInfo:@{
+                          kFIRDiagnosticsDataNotifKey : diagnosticsData,
+                        }];
+      }
     }
-
     [NSException raise:kFirebaseCoreErrorDomain
                 format:@"`[FIRApp configure];` (`FirebaseApp.configure()` in Swift) could not find "
                        @"a valid GoogleService-Info.plist in your project. Please download one "
@@ -293,26 +301,39 @@ - (instancetype)initInstanceWithName:(NSString *)name options:(FIROptions *)opti
 - (BOOL)configureCore {
   [self checkExpectedBundleID];
   if (![self isAppIDValid]) {
-    if (_options.usingOptionsFromDefaultPlist && [self isDataCollectionDefaultEnabled]) {
+    if (_options.usingOptionsFromDefaultPlist && [self isDataCollectionDefaultEnabled] &&
+        NSClassFromString(@"FIRDiagnostics")) {
+      FIRDiagnosticsData *diagnosticsData = [[FIRDiagnosticsData alloc] init];
+      [diagnosticsData insertValueIfNotNil:@([self isDataCollectionDefaultEnabled])
+                                    forKey:kFIRCDIsDataCollectionDefaultEnabledKey];
+      [diagnosticsData insertValueIfNotNil:[FIRApp firebaseUserAgent]
+                                    forKey:kFIRCDFirebaseUserAgentKey];
+      [diagnosticsData insertValueIfNotNil:@(FIRConfigTypeCore) forKey:kFIRCDConfigurationTypeKey];
       [[NSNotificationCenter defaultCenter]
-          postNotificationName:kFIRAppDiagnosticsNotification
+          postNotificationName:kFIRDiagnosticsNotification
                         object:nil
-                      userInfo:@{
-                        kFIRAppDiagnosticsConfigurationTypeKey : @(FIRConfigTypeCore),
-                        kFIRAppDiagnosticsErrorKey : [FIRApp errorForInvalidAppID],
-                      }];
+                      userInfo:@{kFIRDiagnosticsDataNotifKey : diagnosticsData}];
     }
     return NO;
   }
 
-  if ([self isDataCollectionDefaultEnabled]) {
+  if ([self isDataCollectionDefaultEnabled] && NSClassFromString(@"FIRDiagnostics")) {
+    FIRDiagnosticsData *diagnosticsData = [[FIRDiagnosticsData alloc] init];
+    [diagnosticsData insertValueIfNotNil:@([self isDataCollectionDefaultEnabled])
+                                  forKey:kFIRCDIsDataCollectionDefaultEnabledKey];
+    [diagnosticsData insertValueIfNotNil:[FIRApp firebaseUserAgent]
+                                  forKey:kFIRCDFirebaseUserAgentKey];
+    [diagnosticsData insertValueIfNotNil:@(FIRConfigTypeCore) forKey:kFIRCDConfigurationTypeKey];
+    [diagnosticsData insertValueIfNotNil:self.options.googleAppID forKey:kFIRCDGoogleAppIDKey];
+    [diagnosticsData insertValueIfNotNil:self.options.bundleID forKey:kFIRCDBundleIDKey];
+    [diagnosticsData insertValueIfNotNil:@(self.options.usingOptionsFromDefaultPlist)
+                                  forKey:kFIRCDUsingOptionsFromDefaultPlistKey];
+    [diagnosticsData insertValueIfNotNil:self.options.libraryVersionID
+                                  forKey:kFIRCDLibraryVersionIDKey];
     [[NSNotificationCenter defaultCenter]
-        postNotificationName:kFIRAppDiagnosticsNotification
+        postNotificationName:kFIRDiagnosticsNotification
                       object:nil
-                    userInfo:@{
-                      kFIRAppDiagnosticsConfigurationTypeKey : @(FIRConfigTypeCore),
-                      kFIRAppDiagnosticsFIRAppKey : self
-                    }];
+                    userInfo:@{kFIRDiagnosticsDataNotifKey : diagnosticsData}];
   }
 
 #if TARGET_OS_IOS
@@ -809,26 +830,33 @@ + (nullable NSNumber *)readDataCollectionSwitchFromPlist {
 
 #pragma mark - Sending Logs
 
-- (void)sendLogsWithServiceName:(NSString *)serviceName
-                        version:(NSString *)version
-                          error:(NSError *)error {
+- (void)sendLogsWithServiceName:(NSString *)serviceName version:(NSString *)version {
   // If the user has manually turned off data collection, return and don't send logs.
   if (![self isDataCollectionDefaultEnabled]) {
     return;
   }
 
-  NSMutableDictionary *userInfo = [[NSMutableDictionary alloc] initWithDictionary:@{
-    kFIRAppDiagnosticsConfigurationTypeKey : @(FIRConfigTypeSDK),
-    kFIRAppDiagnosticsSDKNameKey : serviceName,
-    kFIRAppDiagnosticsSDKVersionKey : version,
-    kFIRAppDiagnosticsFIRAppKey : self
-  }];
-  if (error) {
-    userInfo[kFIRAppDiagnosticsErrorKey] = error;
+  if (NSClassFromString(@"FIRDiagnostics")) {
+    FIRDiagnosticsData *diagnosticsData = [[FIRDiagnosticsData alloc] init];
+    [diagnosticsData insertValueIfNotNil:@([self isDataCollectionDefaultEnabled])
+                                  forKey:kFIRCDIsDataCollectionDefaultEnabledKey];
+    [diagnosticsData insertValueIfNotNil:[FIRApp firebaseUserAgent]
+                                  forKey:kFIRCDFirebaseUserAgentKey];
+    [diagnosticsData insertValueIfNotNil:@(FIRConfigTypeSDK) forKey:kFIRCDConfigurationTypeKey];
+    [diagnosticsData insertValueIfNotNil:serviceName forKey:kFIRCDSdkNameKey];
+    [diagnosticsData insertValueIfNotNil:version forKey:kFIRCDSdkVersionKey];
+    [diagnosticsData insertValueIfNotNil:self.options.googleAppID forKey:kFIRCDGoogleAppIDKey];
+    [diagnosticsData insertValueIfNotNil:self.options.bundleID forKey:kFIRCDBundleIDKey];
+    [diagnosticsData insertValueIfNotNil:@(self.options.usingOptionsFromDefaultPlist)
+                                  forKey:kFIRCDUsingOptionsFromDefaultPlistKey];
+    [diagnosticsData insertValueIfNotNil:self.options.libraryVersionID
+                                  forKey:kFIRCDLibraryVersionIDKey];
+
+    [[NSNotificationCenter defaultCenter]
+        postNotificationName:kFIRDiagnosticsNotification
+                      object:nil
+                    userInfo:@{kFIRDiagnosticsDataNotifKey : diagnosticsData}];
   }
-  [[NSNotificationCenter defaultCenter] postNotificationName:kFIRAppDiagnosticsNotification
-                                                      object:nil
-                                                    userInfo:userInfo];
 }
 
 @end