Skip to content

Fix FIAM pod lib lint issue #3102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2019
Merged

Fix FIAM pod lib lint issue #3102

merged 1 commit into from
May 29, 2019

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented May 29, 2019

Running locally - pod lib lint FirebaseInAppMessaging.podspec

 -> FirebaseInAppMessaging (0.15.0)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | [iOS] xcodebuild:  note: Planning build
    - NOTE  | [iOS] xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file. (in target 'App')
    - WARN  | xcodebuild:  /Users/paulbeusterien/gh4/firebase-ios-sdk/Firebase/InAppMessaging/Flows/FIRIAMDisplayExecutor.m:59:22: warning: 'messageClicked:' is deprecated [-Wdeprecated-declarations]
    - NOTE  | xcodebuild:  /Users/paulbeusterien/gh4/firebase-ios-sdk/Firebase/InAppMessaging/Public/FIRInAppMessagingRendering.h:338:72: note: 'messageClicked:' has been explicitly marked deprecated here

@paulb777 paulb777 requested review from christibbs and ryanwilson May 29, 2019 00:48
@paulb777 paulb777 mentioned this pull request May 29, 2019
Merged
@paulb777 paulb777 added this to the M49 milestone May 29, 2019
@paulb777 paulb777 merged commit 4ec8087 into master May 29, 2019
@paulb777 paulb777 deleted the pb-fiam-pll branch May 29, 2019 13:46
@firebase firebase locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@christibbs christibbs Awaiting requested review from christibbs

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

6.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@paulb777 @ryanwilson @googlebot